Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds end-to-end test coverage for the server.strictPort configuration option, which controls whether the dev server should throw an error when the requested port is already in use.
- Adds a new e2e test case to verify that dev server startup fails when
strictPortis enabled and the port is occupied - Creates a helper function to programmatically occupy a port for testing purposes
- Implements proper resource cleanup to ensure the blocking server is closed after the test
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| e2e/cases/server/strict-port/index.test.ts | Main test file that verifies strictPort behavior by occupying a port and expecting dev server to throw an error |
| e2e/cases/server/strict-port/rsbuild.config.ts | Basic Rsbuild configuration for the test fixture |
| e2e/cases/server/strict-port/src/index.ts | Minimal source file for the test fixture |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
chenjiahan
deleted the
codex/add-e2e-test-case-for-rsbuild-configuration-sxi22v
branch
1 participant
Summary
Testing
Codex Task